Friend Create Collaboration

[steffest]

I tested the new "collaboration" feature in Friend Create.
Overal this works as intended. Some observations and a few bugs.
(And I'm nitpicking :-))

• Sometimes the wrong file gets shared.
  To reproduce: Open a new file, type something, open a second new file, type something, close the second file. press Co-editing on the first file -> the remote party gets the second file instead of the first.

• When the remote party closes the remote document - the first user is not notified and the green "co-editing" dot remains green.

• When a party initiates co-editing and the remote party presses "undo" , the document gets erased on both sides.

• Websocket connection seems slow at times and key presses don't always land in the same order.
  I have the impression that a remote edit is first send to the remote party, where the actual edit takes place that then gets synced back? (this might have been temporary, it's fast now)

• When a remote party chooses file-> save , or file-> save as , the file is not saved.

• When you co-edit a .jsx file, the remote party still gets the "run" buttons, but nothing happens when clicking that button.

• When 1 party is on the last line of a decument, it is impossible for the other party to add a new line below that line. (because that line is locked and enter is blocked) This measn that if you co-edit a file with 1 line, the other party can't edit the file.

• When you share a file (through sharing, not collaboration), it appears twice in the "shared" menu. Once in a folder with the name of the persion you shared it with, once in a "you shared" folder. Opening both files confuses the editor, where the file is named "undefined" in 1 tab.

• When co-editing and you remove a user, the "collaborating" indicator top right is currectly updated, but the green "co-editing" dot bottom left is still green.

• When co-editing a file, the remote party can't share a file back (there's no "co-editing" button)

• How do I add participants when I am already co-editing? I only have a "disconnect" in the Collaboration menu.

• When the remote party wants to remove a participant, that does not work.

• When the remote party disconnects the collaboration, the remote file is still open. (while when the initiating party disconnects, this file is closed)

• When the remote party declines the invite, there's no notification for the initiating party (he doesn't know if the invite was declined or simply not seen yet)

• It's a stretch, but if you are logged into Friend on multiple places with the same account, and you accept the collaboration invite multiple times. Thisx kind of works, but as the line is not locked for your own account, concurrent edits clash.

• When Friend create is open and you get a collaboration invite, click accept. -> the collaboration starts.
  Whe you click the alert balloon afterwards on the notification icon. Friend Create opens again, but with a disconnected collaboration status.

[titlestad]

Great stuff, thanks @steffest!

[titlestad]

There also seems to be some issues for users who have closed port ranges that WebRTC dynamically operates through. So in this case, the server may need to be calibrated to 443 or a similar port.