-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to view Invidious playlists #4299
base: development
Are you sure you want to change the base?
Add the ability to view Invidious playlists #4299
Conversation
e27d11b
to
c00de4d
Compare
When the local API is selected, you can only support these playlists if backend fallback is enabled, please add the relevant checks. Feel free to take inspiration from how we hide the popular button in the side bar. |
c00de4d
to
1f91214
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Will wait for #4597 to be merged before adding rest of changes (basically the playlist view loads but the playlist on the watch page still has some issues) |
To fix the error simply update searchQueryTextRequested() {
return this.$route.query.searchQueryText ?? ''
}, Coz |
Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
this.playlistId = this.$route.query.playlistId | ||
this.playlistItemId = this.$route.query.playlistItemId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines look identical to the lines, only a few lines further up. Are these needed?
Looks like the share menu on the watch page doesn't work correctly. For the YouTube links it includes the playlist ID, even though it it won't work as it's an Invidious playlist and for the Invidious ones it uses the current instance instead of the playlist's instance. |
I guess we should just remove the playlist id in this case? |
I will be setting this to WIP as I'd like to revisit this once the piped PR is merged (I'd also like to add support for piped playlists) |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
85d59c4
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Add the ability to view Invidious playlists
Pull Request Type
Description
This PR allows us to view Invidious playlists (playlists that were created on Invidious)
Testing
Desktop