Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to view Invidious playlists #4299

Draft
wants to merge 32 commits into
base: development
Choose a base branch
from

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Nov 8, 2023

Add the ability to view Invidious playlists

Pull Request Type

  • Feature Implementation

Description

This PR allows us to view Invidious playlists (playlists that were created on Invidious)

Testing

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 8, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 8, 2023 05:21
@absidue
Copy link
Member

absidue commented Nov 8, 2023

When the local API is selected, you can only support these playlists if backend fallback is enabled, please add the relevant checks. Feel free to take inspiration from how we hide the popular button in the side bar.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@efb4f5ff-1298-471a-8973-3d47447115dc

NOTE: THIS PR SHOULD BE MERGED AFTER: #4234 AND #4242

Could u maybe resolve conflicts so i can do a proper review :)

@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft January 31, 2024 18:03
auto-merge was automatically disabled January 31, 2024 18:03

Pull request was converted to draft

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer
Copy link
Member Author

Will wait for #4597 to be merged before adding rest of changes (basically the playlist view loads but the playlist on the watch page still has some issues)

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Feb 1, 2024
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 1, 2024 15:00
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 1, 2024 15:00
@PikachuEXE
Copy link
Collaborator

To fix the error simply update searchQueryTextRequested() in src/renderer/views/Playlist/Playlist.js to

    searchQueryTextRequested() {
      return this.$route.query.searchQueryText ?? ''
    },

Coz playlist-info expect string but this query can return undefined

Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
PikachuEXE
PikachuEXE previously approved these changes Mar 29, 2024
Comment on lines +1198 to +1199
this.playlistId = this.$route.query.playlistId
this.playlistItemId = this.$route.query.playlistItemId
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines look identical to the lines, only a few lines further up. Are these needed?

@absidue
Copy link
Member

absidue commented Apr 2, 2024

Looks like the share menu on the watch page doesn't work correctly. For the YouTube links it includes the playlist ID, even though it it won't work as it's an Invidious playlist and for the Invidious ones it uses the current instance instead of the playlist's instance.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 2, 2024
@ChunkyProgrammer
Copy link
Member Author

Looks like the share menu on the watch page doesn't work correctly. For the YouTube links it includes the playlist ID, even though it it won't work as it's an Invidious playlist and for the Invidious ones it uses the current instance instead of the playlist's instance.

I guess we should just remove the playlist id in this case?

@ChunkyProgrammer
Copy link
Member Author

I will be setting this to WIP as I'd like to revisit this once the piped PR is merged (I'd also like to add support for piped playlists)

@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft April 2, 2024 21:17
auto-merge was automatically disabled April 2, 2024 21:17

Pull request was converted to draft

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants