Toponaming: replace MultiFuse implementation to fix face colors #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgbsww
force-pushed
the
bgbsww-toponamingNewMultiFuse
branch
from
b9ce9dc
to
fbaa02c
Compare
|
Can this PR have 'broken' Create a Part Box and copy-paste the code below in the Python console. import FreeCAD as App
import Draft
doc = App.ActiveDocument
face = Part.getShape(doc.Box, "Face2", needSubElement=True, retType=0)
shp = Part.Shape()
shp = shp.fuse(face)
print(shp.SubShapes)Version: |
2 tasks
Roy-043
added a commit
to Roy-043/FreeCAD
that referenced
this pull request
May 26, 2024
Fixes FreeCAD#14242. In the current dev fusing an empty shape with a face or solid no longer works (probably introduced with FreeCAD#14169). The reason for starting with an empty shape was the assumption that the end result would then always have a default placement. But that is only correct if multiple objects are fused. In the new version of the code fusing no longer starts with an empty shape. The default placement issue is solved by always returning a compound. Additionally the value for the Area property is now taken after offsetting and fusing the faces.
yorikvanhavre
pushed a commit
that referenced
this pull request
May 27, 2024
Fixes #14242. In the current dev fusing an empty shape with a face or solid no longer works (probably introduced with #14169). The reason for starting with an empty shape was the assumption that the end result would then always have a default placement. But that is only correct if multiple objects are fused. In the new version of the code fusing no longer starts with an empty shape. The default placement issue is solved by always returning a compound. Additionally the value for the Area property is now taken after offsetting and fusing the faces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.