Implements sessions screen. #165
Merged
+330
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji-1009
reviewed
Oct 2, 2023
| } | ||
|
|
||
| extension LocaleTextEx on LocaleText { | ||
| String get(Locale locale) => switch (locale.languageCode) { |
lib/ui/screen/sessions/sessions.dart
Outdated
|
|
||
| return SelectionContainer.disabled( | ||
| child: ListView( | ||
| padding: const EdgeInsets.symmetric(vertical: 16), |
There was a problem hiding this comment.
dartfmtが現時点で対応できていないので、個別にチェックになってしまうのですが、trailing commaを入れてもらっても良いでしょうか 🙏
ref dart-lang/dart_style#1253
また、 horizontal に context.spacing を入れてもらえると、他のページと揃ったmarginがある程度入るようになるかなと思います。
lib/ui/screen/sessions/sessions.dart
Outdated
| ], | ||
| onSelectionChanged: (rooms) { | ||
| if (rooms.isEmpty) return; | ||
| ref.read(selectedRoomProvider.notifier).update(rooms.first); |
There was a problem hiding this comment.
ページ内に閉じる状態管理であれば、ConsumerStatefulWidgetで対応してもいいかもしれないです 🤔
この辺りは、tabの状態をURLと紐づけるかどうかで検討していただければ、と言う感じです！ (仕様を考えましたが、SegmentedButtonで管理する場合には、どちらでもいいかなと思いました)
There was a problem hiding this comment.
それで言うと、むしろURLベースにして ?room=1 とかクエリパラメータで飛べるようにするのもありかなと思ったんですがどうですか？
lib/ui/screen/sessions/sessions.dart
Outdated
| } | ||
|
|
||
| class _SessionSection extends ConsumerWidget { | ||
| const _SessionSection({super.key, required this.session}); |
There was a problem hiding this comment.
半ばanalyzerのご検知のようなのですが、未使用で参照していないことは明らか(private classのため)なので、super.keyは削除で良さそうに思います。
| _ => null, | ||
| }; | ||
|
|
||
| return Card( |
koji-1009
approved these changes
Oct 3, 2023
Co-authored-by: Koji Wakamiya <koji.wakamiya@gmail.com>
|
Commented by GitHub Bot PR: #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist
flutter format lib.dart fix --apply lib.