Add color picker option to accept changes on dismissal #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tryibion
reviewed
Oct 7, 2023
| @@ -148,6 +148,13 @@ public enum PlayAction | |||
| [EditorDisplay("Interface"), EditorOrder(280), Tooltip("Editor content window orientation.")] | |||
| public FlaxEngine.GUI.Orientation ContentWindowOrientation { get; set; } = FlaxEngine.GUI.Orientation.Horizontal; | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the editor content window orientation. | |||
There was a problem hiding this comment.
Probably a copy and paste error here.
| /// </summary> | ||
| [DefaultValue(false)] | ||
| [EditorDisplay("Interface"), EditorOrder(300), Tooltip("If checked, color pickers will always modify the color unless 'Cancel' if pressed, otherwise color won't change unless 'Ok' is pressed (default)")] | ||
| public bool ColorPickerAlwaysChangesColor { get; set; } = false; |
There was a problem hiding this comment.
What about like AutoAcceptOnColorChange or AutoPickOnColkrChange or AutoAcceptColorPickerColor or something? Idk naming things is hard.
There was a problem hiding this comment.
Well, there is nothing really automatic about the option, is it? You still pick the color, is just that the change doesn't need "acknowledgement", but not sure.
Maybe we can say "Color picker magical option 42, surprise!" or something... 😁
There was a problem hiding this comment.
That said "Auto accept color picker change" might just work. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really used to the Unity (and maybe other creative tools) of color picker functionality, where you don't need to press "Ok" for the color to be accepted, just dismissing the dialog is enough.
This PR adds an option to be able to do that, and I'd be grateful if somebody has some feedback on the naming, category location and/or tooltip description, naming is difficult.