Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI option to show line numbers for errors #43

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

fkarg
Copy link
Contributor

@fkarg fkarg commented Sep 30, 2020

Tested/written for usage with Markdown.

  • Fuzzy matches based on rough location estimate
  • Approximates line number in source file
  • Computationally expensive for large files

@Findus23
Copy link
Owner

Findus23 commented Oct 1, 2020

Hi,

This is the only of your changes I am not sure about if I should merge. I honestly never had the need to know the line number of the error (a search in the text editor shows it quickly most of the time) and with the MD/HTML/TeX/etc. conversion it wouldn't work in most cases anyway.

I merged 328d3da and e859890, but if you are okay, I would just add a part in the documentation that mentions the existence of your code in case someone else is interested in this.

@fkarg
Copy link
Contributor Author

fkarg commented Oct 1, 2020

Sure, sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants