Generalize CSC assembler #916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 93.69% 93.66% -0.03%
==========================================
Files 36 36
Lines 5438 5450 +12
==========================================
+ Hits 5095 5105 +10
- Misses 343 345 +2 ☔ View full report in Codecov by Sentry. |
termi-official
added
needs changelog
awaiting review
KnutAM
reviewed
May 16, 2024
KnutAM
reviewed
May 16, 2024
KnutAM
reviewed
May 16, 2024
KnutAM
reviewed
May 16, 2024
termi-official
removed
the
awaiting review
termi-official
added
the
awaiting review
KnutAM
reviewed
May 30, 2024
Co-authored-by: Knut Andreas Meyer <knutam@gmail.com>
…M/Ferrite.jl into do/more-generic-csc-assembler
|
Thanks for the review Knut! I would like to suggest that the removal of the symmetric API should go into a separate PR. |
KnutAM
approved these changes
May 31, 2024
There was a problem hiding this comment.
LGTM.
I like the name-changes, but perhaps there should be a @deprecate_binding or something @fredrikekre ?
I just think we are at a point now that we need to reduce annoyance to users where possible during the upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should be sufficient to allow assembly into CSC matrix types other than SparseMatrixCSC and the Symmtric counterpart.
Also a step towards shaping the interface for #628 , since resize is not allowed on the GPU.
TODOs