Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group sorting #980

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat: add group sorting #980

merged 1 commit into from
Jun 20, 2023

Conversation

DSCaskey
Copy link
Contributor

This adds sorting to the Groups table list via a custom QTableWidgetItem to handle the custom sorting for the boolean and color based columns. Table now contains a Header item with texts V L O C and Name.

groups

closes issue #979

@floe-app-tester
Copy link

This repository is using Floe. When merged, this PR will show up in your inbox. Visit the Floe dashboard to view and modify your changelog.

@what-the-diff
Copy link

what-the-diff bot commented Jun 19, 2023

PR Summary 🎉

  • Introducing makeHeaderName() function!
    Our developer team added a new function, makeHeaderName(), to increase efficiency and maintainability in code.

  • Enhanced groups_widget class!
    Say goodbye to confusing table header names and sorting methods! 😊 The groups_widget class now uses the new function to display user-friendly table header names, sort by column names, and even includes an additional column for group color. 🌈

  • A brand new GroupTableWidgetItem class!
    We're excited to present a new GroupTableWidgetItem class that allows custom sorting for groups in the pattern properties dialog box. Now, you can effortlessly sort by visibility, lock status, and name! 💪🔒

@DSCaskey DSCaskey linked an issue Jun 19, 2023 that may be closed by this pull request
@ghost
Copy link

ghost commented Jun 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86
Copy link
Collaborator

csett86 commented Jun 19, 2023

Also overall looking good, but same as on the other PR, please also update the translation source files, as we have some new strings. Thanks a lot for your features, @DSCaskey

@DSCaskey
Copy link
Contributor Author

but same as on the other PR, please also update the translation source files, as we have some new strings.

I can't run lupdate at the momment... installing Qt 6 messed up some path or include settings.

Also IMO Lupdates should be made separately outside of feature commits so anyone wishing to translate can be notified see an Lupdate PR and not have to dig down into the commit history to see it. Also it's not like there's a translation crew on call 24/7 to make updates, that we couldn't just run periodic lupdates. We should simply be able to run an Lupdate and make a PR whenever without creating an issue.

@csett86 csett86 merged commit 49f53ef into develop Jun 20, 2023
11 checks passed
@csett86 csett86 deleted the issue-979-add-group-sorting branch June 20, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add sorting to the groups list
3 participants