Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve fx dialog #978

Merged
merged 2 commits into from
Jun 20, 2023
Merged

feat: improve fx dialog #978

merged 2 commits into from
Jun 20, 2023

Conversation

DSCaskey
Copy link
Contributor

This improves the functionality of the formula editor dialog. Also cleans up more of the code styling.

This cleans up the layout of the dialog. It replaces the radio buttons with a list widget to provide tabs more consistent with the Preferences and Pattern Piece dialogs.
fx_dialog

Adds a formula reset toolbutton that will reset the formula to formula present when the dialog first opened.

Replaces the "pointing finger" icon with an "insert fx" icon:
insert_fx

It includes some added tooltips:

  • Clear button tooltip
    clear

  • Reset formula tooltip
    reset

  • Insert tooltip
    insert

  • Filter tooltip
    filter_tooltip

  • Function tooltips which now display a usage template for the selected function
    tooltip

This also changes the behavior when a Function is inserted. Inserting a function will now add the parentheses automatically, and will wrap them around any selected text in the formula box.

Closes issue #977

This improves the functionality of the formula editor dialog. Also  cleans up more of the code styling.
@floe-app-tester
Copy link

This repository is using Floe. When merged, this PR will show up in your inbox. Visit the Floe dashboard to view and modify your changelog.

@ghost
Copy link

ghost commented Jun 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DSCaskey DSCaskey linked an issue Jun 19, 2023 that may be closed by this pull request
@csett86
Copy link
Collaborator

csett86 commented Jun 19, 2023

This looks great, thanks a lot for the improvements, @DSCaskey

As it changes quite some strings, can you run lupdate as well please, so that the strings for translation are also up to date?

nmake lupdate

should do it under MSVC, or with mingw probably:

make lupdate

@DSCaskey
Copy link
Contributor Author

As it changes quite some strings, can you run lupdate as well please, so that the strings for translation are also up to date

nmake lupdate

I know that... you can just run lupdate from within Creator. Ludate won't run at the moment... installing Qt6 messed up my kit settings., and I'm trying to sort them out.

@slspencer slspencer merged commit 6319c3d into develop Jun 20, 2023
11 checks passed
@slspencer slspencer deleted the issue-977-improve-fx-dialog branch June 20, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Improve the FX dialog
3 participants