Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UTF-8 sources in MSVC #975

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: UTF-8 sources in MSVC #975

merged 1 commit into from
Jun 16, 2023

Conversation

csett86
Copy link
Collaborator

@csett86 csett86 commented Jun 14, 2023

This forces MSVC to use UTF-8 as source encoding, and with that the degree symbol finally works also when compiled with msvc.

Before:

Bildschirmfoto 2023-06-14 um 22 14 52

After:

Bildschirmfoto 2023-06-14 um 22 13 49

Closes: #315

@floe-app-tester
Copy link

This repository is using Floe. When merged, this PR will show up in your inbox. Visit the Floe dashboard to view and modify your changelog.

@what-the-diff
Copy link

what-the-diff bot commented Jun 14, 2023

PR Summary 🌟

  • UTF-8 Support for MSVC Builds 😃
    We've added a line to common.pri, ensuring consistent UTF-8 encoding for special symbols and characters (like °) in source files on MSVC builds. No worries, g++ users - this change doesn't affect you! We found this helpful change from a [Stack Overflow post](https://stackoverflow.com/questions/48705747/how-utf-8-may not work in qt 5). 🎉

@ghost
Copy link

ghost commented Jun 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86 csett86 marked this pull request as ready for review June 14, 2023 20:16
@DSCaskey
Copy link
Contributor

I tested this and it also takes care of the base label strings - so it looks good to me to merge.

@csett86 csett86 merged commit 000ce5d into develop Jun 16, 2023
11 checks passed
@csett86 csett86 deleted the fix-utf8-msvc branch June 16, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: UTF-8 encoding issue
2 participants