Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdf export from draft mode #974

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

DSCaskey
Copy link
Contributor

This fixes the pdf export from draft mode. Puts the target qrect() in rectangle coordinates instead of the source qrect() scene coordinates.

Closes issue #973

@floe-app-tester
Copy link

This repository is using Floe. When merged, this PR will show up in your inbox. Visit the Floe dashboard to view and modify your changelog.

@ghost
Copy link

ghost commented Jun 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this!

@csett86 csett86 merged commit 75acbbd into develop Jun 15, 2023
11 checks passed
@csett86 csett86 deleted the isue-973-pdf-export-from-draft-mode branch June 15, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: PDF export from draft mode does not display correctly in PDF reader
2 participants