Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save as dialogs #912

Merged
merged 8 commits into from
Mar 30, 2023
Merged

fix: save as dialogs #912

merged 8 commits into from
Mar 30, 2023

Conversation

DSCaskey
Copy link
Contributor

This fixes issue #380

  • When you saveAs() the current file, the name is now displayed in the dialog instead of the default “pattern” or “measurements”.

Screenshot (1371)

  • Doing a saveAs() with the current filename bypasses the lock check so it’s as if you just save()'d the file.

  • The window title bar now displays the App name first followed by the full path of the filename, and in the case of Seamly2D the pattern name is still followed by any associated measurement file.

title

Closes: Issue #380

@DSCaskey DSCaskey requested a review from slspencer March 30, 2023 01:38
@DSCaskey DSCaskey self-assigned this Mar 30, 2023
@csett86 csett86 linked an issue Mar 30, 2023 that may be closed by this pull request
@slspencer slspencer merged commit ea0c6f2 into develop Mar 30, 2023
6 checks passed
@csett86 csett86 deleted the issue-380-fix-Save-as-dialogs branch April 8, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Issue when using SaveAs
2 participants