-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue 147 improve group tool #905
Conversation
Hey! Changelogs info seems to be missing or might be in incorrect format. |
Reran job with debugging, here's more detail:
|
…hionFreedom/Seamly2D into issue-147-improve-group-tool
I get the missing commits on the icons... Have no clue how the PNG ucase got there in the qrc? And who knew the qrc is case sensitive,... one more thing to keeo track of. < sigh > Problem is, Creator doesn't care about uncommitted files or case in file names - it just builds with what ever is in the pro, pri & qrc files. |
BTW .. can we PLEASE settle on 1 format for PR titles? I was using bug / feat issue # dadada.... and @csett86 started removing the issue #'s... so I went with that. Now @slspencer added the issue # back on this one. < sigh > Also can we be consistent between issues and pr's so we dont have Feature: in issues and feat: in PR's or BUG: and bug: etc... This sort of thing drives me nuts. |
I re-installed Changelogg and we started getting the comment above that we should add tags in a certain way. So I started updating them and it works. So follow the Changelogg tags format in the PR header or in the descript. I like the PR header, but as long as the PR header or tagged description phrase shows up in the changelog then it's all good. |
First of all, sorry for the annoyance! To explain: I also based it on Changelogg, so typically its feat: Some new feature or fix: Previously broken thing or docs: Something improved in the documentation I would not add the issue in the summary, as thats relatively unusual. Instead, as the last line in the commit message, put something like Closes: #123 Then github detects that and automatically links the PR and the issue. Do you agree Susan and @DSCaskey |
I would not add the issue in the summary, as thats relatively unusual.
Instead, as the last line in the commit message, put something like
Closes: #123 <#123>
Then github detects that and automatically links the PR and the issue.
I always add the Closes issue... as far as adding the issue # in the title
I don't care one way or another... as long as everyone is on the same page
and you'll don't keep changing the title on me. I'm agreeable to leave the
issue # off the PR titles.
…On Sat, Mar 25, 2023, 5:07 PM Douglas Caskey ***@***.***> wrote:
>I would not add the issue in the summary, as thats relatively unusual.
Instead, as the last line in the commit message, put something like
On Sat, Mar 25, 2023, 7:53 AM Christoph Settgast ***@***.***>
wrote:
> First of all, sorry for the annoyance!
>
> To explain: I also based it on Changelogg, so typically its
>
> feat: Some new feature
>
> or
>
> fix: Previously broken thing
>
> or
>
> docs: Something improved in the documentation
>
> I would not add the issue in the summary, as thats relatively unusual.
> Instead, as the last line in the commit message, put something like
>
> Closes: #123 <#123>
>
> Then github detects that and automatically links the PR and the issue.
>
> Do you agree Susan and @DSCaskey <https://github.com/DSCaskey>
>
> —
> Reply to this email directly, view it on GitHub
> <#905 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHTXADVPMP53IUVEXXAC633W53ME5ANCNFSM6AAAAAAWFYHVUY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
I would not add the issue in the summary, as thats relatively unusual.
Instead, as the last line in the commit message, put something like
…On Sat, Mar 25, 2023, 7:53 AM Christoph Settgast ***@***.***> wrote:
First of all, sorry for the annoyance!
To explain: I also based it on Changelogg, so typically its
feat: Some new feature
or
fix: Previously broken thing
or
docs: Something improved in the documentation
I would not add the issue in the summary, as thats relatively unusual.
Instead, as the last line in the commit message, put something like
Closes: #123 <#123>
Then github detects that and automatically links the PR and the issue.
Do you agree Susan and @DSCaskey <https://github.com/DSCaskey>
—
Reply to this email directly, view it on GitHub
<#905 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHTXADVPMP53IUVEXXAC633W53ME5ANCNFSM6AAAAAAWFYHVUY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds good. For the last line in the commit message, it needs to be very specific, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
Expands the Group Manager and from the a new tool widget which you can:
The Groups table will now display whether it’s visible, locked, contains objects, and the group color (the default is black. Below the Groups table is a new Objects list, which will display a list of the objects in the selected group.
As well as using the Group tool to add multiple selected objects to a group, using the context menu allows a user to add or delete a single selected object to / from a group.
Merging closes issue #147