Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Issue 147 improve group tool #905

Merged
merged 38 commits into from
Mar 25, 2023
Merged

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Mar 23, 2023

Expands the Group Manager and from the a new tool widget which you can:

  • Show All Groups
  • Hide All Groups
  • Lock All Groups
  • Unlock All Groups
  • Add New Group
  • Delete Existing Group
  • Edit Existing Group

The Groups table will now display whether it’s visible, locked, contains objects, and the group color (the default is black. Below the Groups table is a new Objects list, which will display a list of the objects in the selected group.

  • Double clicking an item in the Objects list will zoom to that object or a point of the object
  • Context menu will provide items to move or delete an object from the selected group
  • Docks are now vertically tabbed to make better use of the dock space and reduce the need to scroll

GroupDock

items_context

As well as using the Group tool to add multiple selected objects to a group, using the context menu allows a user to add or delete a single selected object to / from a group.

object_context

Merging closes issue #147

@changelogg
Copy link

changelogg bot commented Mar 23, 2023

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@slspencer slspencer changed the title Issue 147 improve group tool fix: Issue 147 improve group tool Mar 24, 2023
@slspencer slspencer changed the title fix: Issue 147 improve group tool feat: Issue 147 improve group tool Mar 24, 2023
@slspencer
Copy link
Collaborator

Reran job with debugging, here's more detail:

/home/runner/work/Seamly2D/Qt/5.15.2/gcc_64/bin/rcc -name theme share/resources/theme.qrc -o qrc_theme.cpp
make[3]: *** No rule to make target 'share/resources/icon/32x32/add.PNG', needed by 'qrc_icon.cpp'.  Stop.
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/runner/work/Seamly2D/Seamly2D/src/libs/vmisc'
make[2]: *** [Makefile:260: sub-vmisc-make_first] Error 2

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 24, 2023

I get the missing commits on the icons... Have no clue how the PNG ucase got there in the qrc? And who knew the qrc is case sensitive,... one more thing to keeo track of. < sigh > Problem is, Creator doesn't care about uncommitted files or case in file names - it just builds with what ever is in the pro, pri & qrc files.

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 24, 2023

@slspencer
@csett86

BTW .. can we PLEASE settle on 1 format for PR titles? I was using bug / feat issue # dadada.... and @csett86 started removing the issue #'s... so I went with that. Now @slspencer added the issue # back on this one. < sigh >

Also can we be consistent between issues and pr's so we dont have Feature: in issues and feat: in PR's or BUG: and bug: etc... This sort of thing drives me nuts.

@slspencer
Copy link
Collaborator

slspencer commented Mar 25, 2023

BTW .. can we PLEASE settle on 1 format for PR titles? I was using bug / feat issue # dadada.... and @csett86 started removing the issue #'s... so I went with that. Now @slspencer added the issue # back on this one. < sigh >

I re-installed Changelogg and we started getting the comment above that we should add tags in a certain way. So I started updating them and it works. So follow the Changelogg tags format in the PR header or in the descript. I like the PR header, but as long as the PR header or tagged description phrase shows up in the changelog then it's all good.

@slspencer slspencer merged commit 0916742 into develop Mar 25, 2023
@slspencer slspencer deleted the issue-147-improve-group-tool branch March 25, 2023 01:15
@csett86
Copy link
Collaborator

csett86 commented Mar 25, 2023

First of all, sorry for the annoyance!

To explain: I also based it on Changelogg, so typically its

feat: Some new feature

or

fix: Previously broken thing

or

docs: Something improved in the documentation

I would not add the issue in the summary, as thats relatively unusual. Instead, as the last line in the commit message, put something like

Closes: #123

Then github detects that and automatically links the PR and the issue.

Do you agree Susan and @DSCaskey

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 25, 2023 via email

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 25, 2023 via email

@csett86
Copy link
Collaborator

csett86 commented Mar 25, 2023

Sounds good.

For the last line in the commit message, it needs to be very specific, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants