Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completed Dutch translations #903

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

pmjherman
Copy link
Contributor

@pmjherman pmjherman commented Mar 22, 2023

  • feat: I have completed the nl_NL translations, to incorporate all the new terms after recent changes in the user interface. Only the Dutch translation file is affected.

@changelogg
Copy link

changelogg bot commented Mar 22, 2023

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@DSCaskey DSCaskey requested a review from csett86 March 22, 2023 22:14
@DSCaskey DSCaskey linked an issue Mar 22, 2023 that may be closed by this pull request
@DSCaskey DSCaskey changed the title #902: Feature: Completed nl_NL translations feat: completed Dutch translations #902 Mar 22, 2023
@DSCaskey DSCaskey changed the title feat: completed Dutch translations #902 feat: completed Dutch translations Mar 22, 2023
@pmjherman
Copy link
Contributor Author

Sorry, I was too early with making the pull request. I now found out that a test failed because in the History dialog there is a string "Point Length and Angle from point %2" which has a placeholder %2, but not a placeholder %1. Or at least that is how I understand it. The literal text from the test log is:
"FAIL! : TST_TSTranslation::CheckPlaceMarkerExist(File 'seamly2d_nl_NL.ts'. Check place holder source message 'Point Length and Angle from point %2') In source string 'Point Length and Angle from point %2' was missed place marker '%1'.
Loc: [../../../../Seamly2D/src/test/TranslationsTest/tst_tstranslation.cpp(289)]"

I do not think this can be corrected in the translation file. Is it a problem in the source?

Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank a lot @pmjherman

@slspencer slspencer merged commit 08ed875 into FashionFreedom:develop Mar 23, 2023
@pmjherman pmjherman deleted the nl_translation branch March 23, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: complete nl_NL translations after recent updates
4 participants