Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve history dialog #884

Merged
merged 12 commits into from
Mar 20, 2023
Merged

feat: Improve history dialog #884

merged 12 commits into from
Mar 20, 2023

Conversation

DSCaskey
Copy link
Contributor

Improves the History Dialog

  • Change Tool name format for tool description.
  • Adds display of the Tool id number.
  • Adds Tool icon to description.
  • Adds Copy to Clipboard tool button to be able to cut and paste history into other apps.

history

Closes issue #883

@DSCaskey DSCaskey requested a review from slspencer March 14, 2023 17:40
@DSCaskey DSCaskey self-assigned this Mar 14, 2023
@DSCaskey DSCaskey linked an issue Mar 14, 2023 that may be closed by this pull request
Feature: Improve History Dialog #883
Closed
slspencer
slspencer requested changes Mar 16, 2023
View reviewed changes
share/translations/translations.pro Outdated Show resolved Hide resolved
csett86
csett86 reviewed Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert it by applying the suggestion that I just left

share/translations/translations.pro Outdated Show resolved Hide resolved
slspencer
slspencer requested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@slspencer slspencer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts with the following files:

  • share/translations/seamly2d_cs_CZ.ts
  • share/translations/seamly2d_de_DE.ts
  • share/translations/seamly2d_el_GR.ts
  • share/translations/seamly2d_en_CA.ts
  • share/translations/seamly2d_en_IN.ts
  • share/translations/seamly2d_en_US.ts
  • share/translations/seamly2d_es_ES.ts
  • share/translations/seamly2d_fi_FI.ts
  • share/translations/seamly2d_fr_FR.ts
  • share/translations/seamly2d_he_IL.ts
  • share/translations/seamly2d_id_ID.ts
  • share/translations/seamly2d_it_IT.ts
  • share/translations/seamly2d_nl_NL.ts
  • share/translations/seamly2d_pt_BR.ts
  • share/translations/seamly2d_ro_RO.ts
  • share/translations/seamly2d_ru_RU.ts
  • share/translations/seamly2d_uk_UA.ts
  • share/translations/seamly2d_zh_CN.ts

@slspencer slspencer merged commit 81693cd into develop Mar 20, 2023
@csett86 csett86 deleted the issue-883-update-history-dialog branch March 21, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csett86 csett86 csett86 left review comments

@slspencer slspencer slspencer requested changes

Assignees

@DSCaskey DSCaskey

Labels
Draft mode enhancement history UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Improve History Dialog
3 participants
@DSCaskey @slspencer @csett86