Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Consistent look&feel for dialogs and property editor #882

Merged
merged 18 commits into from
Mar 20, 2023
Merged

feat: Consistent look&feel for dialogs and property editor #882

merged 18 commits into from
Mar 20, 2023

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Mar 9, 2023

Implements issue #881 .

New pen style toolbar:

pentoolbar

Typical display of updated tool dialogs and Property Editor"

Screenshot (1287)

@DSCaskey DSCaskey requested a review from slspencer March 9, 2023 12:28
@DSCaskey DSCaskey self-assigned this Mar 9, 2023
@changelogg
Copy link

changelogg bot commented Mar 9, 2023

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 9, 2023

Merging closes issue #882

@DSCaskey DSCaskey linked an issue Mar 9, 2023 that may be closed by this pull request
Feature: Update tool Dialogs and Property Editor #881
Closed
@DSCaskey
Copy link
Contributor Author

DSCaskey commented Mar 9, 2023

Don't merge yet... there's an issue with the Move tool in the Properties Editor.

@DSCaskey
Copy link
Contributor Author

Property Editor issues fixed. Should be OK to merge now. :)

csett86
csett86 reviewed Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSCaskey First of all: Awesome and massive work here, thank you! Also tested on macOS, looks great there as well.

Just a very small note: As you are restoring the share/translations/translations.pro file, please also restore the share/translations/measurements.pro

See #880 or merge in the branch restore-translation-lupdate into your PR.

share/translations/translations.pro Outdated Show resolved Hide resolved
csett86 and others added 2 commits March 13, 2023 22:06
@csett86
Restore files required for lupdate
8ff201b 
To run lupdate, these pro files are required. Thus revert parts
of 174e987 and clean up the files to
match the new structure without the pmsystems and without transifex.com
@DSCaskey
Merge branch 'restore-translation-lupdate' into issue-881-update-dial…
922c0be 
…ogs-and-property-editor
slspencer
slspencer requested changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@slspencer slspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSCaskey - Spectacular work! After the TMP file is removed this will be approved & merged.

src/app/seamly2d/mainwindow.cpp Show resolved Hide resolved
src/app/seamly2d/mainwindow.cpp Show resolved Hide resolved
src/libs/vtools/tools/drawTools/operation/vtoolmove.cpp~RF197adde1.TMP Outdated Show resolved Hide resolved
@DSCaskey
Copy link
Contributor Author

TMP file was removed.

@csett86 csett86 changed the title Issue 881 update dialogs and property editor feat: Consistent look&feel for dialogs and property editor Mar 16, 2023
@slspencer slspencer merged commit 731993a into develop Mar 20, 2023
@slspencer slspencer deleted the issue-881-update-dialogs-and-property-editor branch March 20, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csett86 csett86 csett86 left review comments

@slspencer slspencer slspencer approved these changes

Assignees

@DSCaskey DSCaskey

Labels
Draft mode enhancement UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Update tool Dialogs and Property Editor
3 participants
@DSCaskey @slspencer @csett86