Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch formula length and angle order in property editor for interactive curve #1106

Merged
merged 2 commits into from
May 10, 2024

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented May 5, 2024

This switches the order of the length and angle formula fields for the Curve - Interactive tool in the Property Editor so it matches the order in the dialog.

image

image

Fixes issue #1105

Copy link

what-the-diff bot commented May 5, 2024

PR Summary 📑

  • Exciting new updates in Spline Tool options 🚀

    • We have introduced a property for "C1: angle". The intention here is to allow more customization, thereby enabling you to design with precision and perfection. 📐
    • Additionally, we've improved the order of properties. This will significantly enhance the user interface, making it more intuitive and user-friendly. 👥
  • Advanced property setting for your needs 🔧

    • We've also added an extra property for "C2: angle". This gives you added control you've always desired, bringing more power to your fingertips. 💪

Your work is going to get more exciting and effortless with these enhancements! Your creativity is no longer restricted by limitations; instead, it is boosted by possibilities and precision! Let's keep innovating, together! 👏💼

@DSCaskey
Copy link
Contributor Author

DSCaskey commented May 7, 2024

Hey @csett86,

Somehow we inadvertantly enabled that commits need to be signed, and currently my git client is not setup to sign commits, so Susan turned it off for now. I'll play around with the commit signing on my fork, and we can look at enabling it again in the future. In the mean time I'll probably delete this PR and just submit a new one, as apparently once you make an unsigned commit the only way to fix it is to rebase and force the commit.

@csett86
Copy link
Collaborator

csett86 commented May 8, 2024

Hi @DSCaskey dont delete this PR, I will disable the windows signing (due to the expired certificate) and then this PR is good to go

@DSCaskey
Copy link
Contributor Author

DSCaskey commented May 8, 2024 via email

@csett86 csett86 merged commit cdcd529 into develop May 10, 2024
10 checks passed
@csett86 csett86 deleted the fix-properties-editor branch May 10, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: field order differs between property editor and dialog for interactive curve tool
2 participants