Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Enhance and update about dialog #1095

Merged
merged 9 commits into from Apr 20, 2024

Conversation

DSCaskey
Copy link
Contributor

This enhances the layout of the About dialog and updates the contributors.

Dialog is now split into 3 tabs.

  • About - Displays the basic build and legal information. This tab also adds a Copy to Clipboard that copies the build and system information to the clipboard that can then be pasted into for ex: a bug report.

  • Moves the downloading widget to the button box area .

  • Now displays the proper compiler version for MSVC when MSVC 2019 or greater.

    Screenshot 2024-04-20 033348

  • System - Displays extended information about the build and machine system.

    Screenshot 2024-04-20 002652

  • Contributors - Displays the list of project contributors. Fixes the list so it is actually in alphabetical order. Updates the list with new contributors.

    Screenshot 2024-04-20 002736

  • Fixes the Image Dialog so it is parented to the Mainwindow.

This closes issue #1094

@DSCaskey DSCaskey requested a review from csett86 April 20, 2024 08:21
@DSCaskey DSCaskey self-assigned this Apr 20, 2024
@DSCaskey DSCaskey linked an issue Apr 20, 2024 that may be closed by this pull request
Copy link

what-the-diff bot commented Apr 20, 2024

🚀 PR Summary

What an exciting progress! 🎉 Let's go through the amazing changes this PR brings to the table:

  • 🌟 Added a new dialogue, "About 2D App". This is encapsulated in two new files about2d_dialog.cpp and about2d_dialog.h in src/app/seamly2d/dialogs directory. This creative move enhances our application UX by providing impactful information about the 2D feature of our app. 😎

  • 👋 Said goodbye to old code. Removed the "About App" dialog, reflected in the removal of dialogaboutapp.cpp and dialogaboutapp.h. But don't worry! 😇 We replaced it with our shiny new "About 2D App" dialog.

  • 🔄 Revamped some lines in mainwindow.cpp to ensure communication is on point! Can't read image was changed to a more intuitive Import Image and we switched DialogAboutApp with About2DAppDialog in two places. Small stuff but they're making the app better one step at a time. 🚶‍♀️🚶‍♂️

  • 🧽 Gave mainwindow.ui a little clean-up. We swept away trailing whitespace and extra space in the Text property of Images tools QMenu action. Cleanliness is next to effectiveness! 🧹💯

  • 🛠️ Some under-the-hood changes. In image_dialog.cpp, the nameChanged function was replaced with ui->filename_Label. A subtle change that makes things work even better!

  • 👌 Tweaked the image_dialog.ui. We changed the maximum width of the dialog and rearranged certain items in the layout, making the UI more pleasing 😍 We also added a QLabel widget for the "filename" label.

  • 🎁 Lastly, in src/libs/vmisc/projectversion.cpp, we added if statements to check the value of _MSC_VER and return the corresponding MSVC version string. Think of it as our way of making sure the app knows what's up. 🧠

Keep up the good work, team! Excited to see these changes in action! 🚀🌈

@csett86
Copy link
Collaborator

csett86 commented Apr 20, 2024

Overall looks great, thank you!

I checked on macOS and there the build date (using the artifact from the github action) did not show, only the time:

Bildschirmfoto 2024-04-20 um 18 48 09

It happens both in the general and in the more detailed system dialog:

Bildschirmfoto 2024-04-20 um 18 48 13

Other than that it looks good:

Bildschirmfoto 2024-04-20 um 18 48 15

I'll check if the build date works on the current releases.

@csett86
Copy link
Collaborator

csett86 commented Apr 20, 2024

Yes, currently its still working fine on macOS (with latest release 2024.4.15):

Bildschirmfoto 2024-04-20 um 18 56 58

Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great, just the build date is broken on any non-US locale, but that should be an easy fix by reverting to the previous line of code

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Apr 20, 2024

@csett86

Overall great, just the build date is broken on any non-US locale, but that should be an easy fix by reverting to the previous line of code

I checked the code... seems that there's a difference between QLocale() and QLocale::c() with the date. I reverted the date back to QLocale::c() so it should be fine now.

Signed-off-by: Christoph Settgast <csett86_git@quicksands.de>
@DSCaskey
Copy link
Contributor Author

@csett86

Did the change back to QLocale::c() fix the date issue? If so can we merge?

@csett86
Copy link
Collaborator

csett86 commented Apr 20, 2024

Yes, its now looking good, I also just fixed the German translation as we are on it anyway (It was wrong before already, no regression, just while testing it I noticed it):

Bildschirmfoto 2024-04-20 um 21 09 25

I'll now merge

@csett86 csett86 merged commit 0bce425 into develop Apr 20, 2024
10 checks passed
@csett86 csett86 deleted the enhance-and-update-about-dialog branch April 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: enhance and update the About dialog
2 participants