New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Enhance and update about dialog #1095
Conversation
🚀 PR SummaryWhat an exciting progress! 🎉 Let's go through the amazing changes this PR brings to the table:
Keep up the good work, team! Excited to see these changes in action! 🚀🌈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great, just the build date is broken on any non-US locale, but that should be an easy fix by reverting to the previous line of code
I checked the code... seems that there's a difference between QLocale() and QLocale::c() with the date. I reverted the date back to QLocale::c() so it should be fine now. |
Signed-off-by: Christoph Settgast <csett86_git@quicksands.de>
Did the change back to QLocale::c() fix the date issue? If so can we merge? |
This enhances the layout of the About dialog and updates the contributors.
Dialog is now split into 3 tabs.
About - Displays the basic build and legal information. This tab also adds a Copy to Clipboard that copies the build and system information to the clipboard that can then be pasted into for ex: a bug report.
Moves the downloading widget to the button box area .
Now displays the proper compiler version for MSVC when MSVC 2019 or greater.
System - Displays extended information about the build and machine system.
Contributors - Displays the list of project contributors. Fixes the list so it is actually in alphabetical order. Updates the list with new contributors.
Fixes the Image Dialog so it is parented to the Mainwindow.
This closes issue #1094