Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes that prevent from building #1093

Closed
wants to merge 2 commits into from

Conversation

xypp3
Copy link

@xypp3 xypp3 commented Apr 18, 2024

  • Include qobject.h in ifcdef.cpp in the ifc library
  • Remove warings from export_layout_dialog.cpp by adding in a string literal into the constructor function

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

what-the-diff bot commented Apr 18, 2024

Making Things Better! 🎉👏

Fantastic work team! Some neat updates have been pushed and I'm here to take you through the magic behind the curtain in a jargon-free way!

  • A Tiny, Mighty Change in export_layout_dialog.cpp! 😃
    A small yet powerful update has been made in our code. Instead of using a 'QString' that was empty, now we have an '"empty string literal"'. In the simplest words, just think of it like cleaning and freeing up a tiny room (QString) which was empty, for more important tasks. Bravo for the clean-up work, team! ✨

  • Inviting a New Friend to ifdef.cpp, say hello to qobject.h 🎁
    Another file called qobject.h has been invited into ifdef.cpp. It's like inviting a new person to join the party (our code). This addition provides us with more abilities that may help us achieve our goals faster! Excellent job team on this successful invitation! 🎈

And that's the roundup. Keep up the amazing job team, your small changes make our project shine brighter! 😊🚀

@xypp3 xypp3 closed this Apr 18, 2024
@xypp3 xypp3 deleted the minor-fixes branch April 18, 2024 10:14
@xypp3
Copy link
Author

xypp3 commented Apr 18, 2024

Sorry I made the PR to the wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants