-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background image feature MVP #1085
Conversation
Adds the ability to load images onto the background of the draft scene.
"MainWindow::handleImageSelected" has been kept for the future development of this feature
…the image properties dialog
Now ctrl is used to resize the images from their center points
Visibility and origin point options have been hidden.
…cts the manual resizing using the handles
…pect ratio if the corresponding option was set in image properties
Minor refactoring of the code of the delete button
…boxes of the image properties dialog
…th xScale and yScale
Can't build the PR... there's conflicts in the ts files (as well as few other minor conflicts). Not sure what happened, but I got the same conflict warning awhile ago when I tried to fetch changes on your local branch. There's 100's of conflicts in each ts, so I think you're going to need to copy the ts files from the main or your develop and rerun lupdate. I found it best to merge / rebase current develop into the local feature before pushing the branch and a making a PR. It's avoid having conflicts in the PR. |
Also to note: The updated dialog is all wonky now. The labels don't line up vertically anymore which I suspect is from not putting the changed widgets in the proper layout(s). And I'm not sure why there is now a big space between the labels: and the widgets - except for 2 the 2 lock ones that are correct? I'm wondering too if maybe the Lock Image might not be better placed in the Selection group at the top? |
I think the issue is only the "Lock Image" which is not aligned with the "Unit:" and "Lock aspect ratio:" labels. Aligning the 3 "label + button" together in the center seemed a good solution. The buttons are aligned together and the labels should be aligned together on their left side.
It was in order to keep the above alignement, because with the buttons aligned, since the labels have different length it seemed very messy, we spent a lot of time trying to find a proper layout but it seems that it is still not perfect haha. The issue is not "technical" but more of a "GUI design" one 😉
Good idea, I'll try! |
@DSCaskey The conflicts have been solved, and the misalignment in the dialog has been corrected 😉 |
MVP for the Issue #440
The user can add background images to the scene.
Those images are not saved into the pattern file in this first version of the feature and they are not affected by the "undo".
The user can interact with those images and change their properties :
closes issue #440