Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: add locations to lupdate #1072

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Mar 13, 2024

This adds the location tags to translation ts files so that either the source code or the Ui form where the source text is found will be displayed in the Sources and Forms window. In the case of the Ui forms it will also display the translated text in the form.

image

image

To include the locations tags lupdate needs to be run with the -locations option, and in this case used the -locations relative option.

@DSCaskey DSCaskey requested a review from csett86 March 13, 2024 20:50
@DSCaskey DSCaskey self-assigned this Mar 13, 2024
Signed-off-by: Christoph Settgast <csett86_git@quicksands.de>
… dont have any meaningful ui files

Signed-off-by: Christoph Settgast <csett86_git@quicksands.de>
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats great to see the UI in Linguist, thank you for adding this!

I added it as well to the make lupdate target, so that it does not get lost when I run lupdate via make.

@DSCaskey
Copy link
Contributor Author

@csett86

Looks good to me. Thanks for adding this to the pro file.

@DSCaskey DSCaskey merged commit 5e836e3 into develop Mar 16, 2024
10 checks passed
@DSCaskey DSCaskey deleted the add-location-tags-to-lupdate branch March 16, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants