Skip to content

Commit

Permalink
Merge pull request #243 from FashionFreedom/issue-242_Qt5.12
Browse files Browse the repository at this point in the history
Update to Qt 5.12.x, QtCreator 4.11.x
  • Loading branch information
slspencer committed Jun 18, 2020
2 parents 4db200d + 852f23d commit a034db9
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ ___________________________________________________
## Build Seamly2D

Basic Software Prerequisites:
* Qt 5.7.0 or later - https://www.qt.io/download-open-source (includes Qt, QtCreator, and QtChooser)
* QtCreator 4.3.1 or later (to build code)
* Qt 5.12.0 or later - https://www.qt.io/download-open-source (includes Qt, QtCreator, and QtChooser)
* QtCreator 4.11.2 or later (to build code)
* QtChooser (to select or update Qt version)
* Git - either Git from https://git-scm.com/downloads or Github Desktop (recommended for Windows and Mac) from https://desktop.github.com/
* Compiler - either gcc from https://gcc.gnu.org, or mingw from https://sourceforge.net/projects/mingw/
Expand Down
4 changes: 2 additions & 2 deletions README.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ Building Seamly2D
================

Basic Prerequisites:
* Qt 5.7.0 or later - https://www.qt.io/download-open-source (includes Qt, QtCreator, and QtChooser)
* QtCreator 4.3.1 or later (to build code)
* Qt 5.12.0 or later - https://www.qt.io/download-open-source (includes Qt, QtCreator, and QtChooser)
* QtCreator 4.11.2 or later (to build code)
* QtChooser (to select or update Qt version)
* Git - either Git from https://git-scm.com/downloads or Github Desktop (recommended for Windows and Mac) from https://desktop.github.com/
* Compiler - gcc from https://gcc.gnu.org, clang from https://clang.llvm.org/, or mingw from https://sourceforge.net/projects/mingw/
Expand Down
6 changes: 3 additions & 3 deletions Seamly2D.pro
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
include(common.pri)

message("Entering Seamly2D.pro")
#Check if Qt version >= 5.7.0
#!minQtVersion(5, 7, 0) {
#Check if Qt version >= 5.12.0
#!minQtVersion(5, 12, 0) {
# message("Seamly2D.pro: Cannot build Seamly2D with Qt version $${QT_VERSION}.")
# error("Use at least Qt 5.7.0.")
# error("Use at least Qt 5.12.0.")
#}

#These checks need because we can quote all paths that contain space.
Expand Down
8 changes: 4 additions & 4 deletions scripts/macfixqtdylibrpath.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import sys
import getopt

# ./macfixqtdylibrpath.py ./Seamly2D.app /Users/dismine/Qt5.7.0/5.7/clang_64/bin/qmake
# ./macfixqtdylibrpath.py ./Seamly2D.app /Users/dismine/Qt5.12.0/5.12/clang_64/bin/qmake
def usage():
print "Usage: %s <path_to_bundle_root_directory> [qmake_path]" % os.path.basename(sys.argv[0])

Expand Down Expand Up @@ -38,11 +38,11 @@ def findQtLibraries(filter):
wholefiles = []
for root, subdirs, filenames in os.walk('.'):
for filename in filenames:
wholefiles.append(os.path.join(root, filename))
wholefiles.append(os.path.join(root, filename))

filtered = []
for filtered_file in fnmatch.filter(wholefiles, filter):
filtered.append(filtered_file)
filtered.append(filtered_file)
return filtered

def which(program):
Expand Down Expand Up @@ -110,7 +110,7 @@ def main():
print "qmake path: " + qmake_bin

QT_INSTALL_LIBS = readQmakeVar(qmake_bin, 'QT_INSTALL_LIBS')
print "Path to Qt libraries: " + QT_INSTALL_LIBS
print "Path to Qt libraries: " + QT_INSTALL_LIBS

fixFrameworks(QT_INSTALL_LIBS)
fixDylibs(QT_INSTALL_LIBS)
Expand Down
4 changes: 2 additions & 2 deletions src/test/CollectionTest/target_wrapper.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
LD_LIBRARY_PATH=/home/susan/Qt/5.7/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
LD_LIBRARY_PATH=/home/susan/Qt/5.12/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
export LD_LIBRARY_PATH
QT_PLUGIN_PATH=/home/susan/Qt/5.7/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
QT_PLUGIN_PATH=/home/susan/Qt/5.12/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
export QT_PLUGIN_PATH
exec "$@"
4 changes: 2 additions & 2 deletions src/test/ParserTest/target_wrapper.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
LD_LIBRARY_PATH=/home/susan/Qt/5.7/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
LD_LIBRARY_PATH=/home/susan/Qt/5.12/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
export LD_LIBRARY_PATH
QT_PLUGIN_PATH=/home/susan/Qt/5.7/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
QT_PLUGIN_PATH=/home/susan/Qt/5.12/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
export QT_PLUGIN_PATH
exec "$@"
4 changes: 2 additions & 2 deletions src/test/Seamly2DTest/target_wrapper.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
LD_LIBRARY_PATH=/home/susan/Qt/5.7/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
LD_LIBRARY_PATH=/home/susan/Qt/5.12/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
export LD_LIBRARY_PATH
QT_PLUGIN_PATH=/home/susan/Qt/5.7/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
QT_PLUGIN_PATH=/home/susan/Qt/5.12/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
export QT_PLUGIN_PATH
exec "$@"
4 changes: 2 additions & 2 deletions src/test/TranslationsTest/target_wrapper.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
LD_LIBRARY_PATH=/home/susan/Qt/5.7/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
LD_LIBRARY_PATH=/home/susan/Qt/5.12/gcc_64/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
export LD_LIBRARY_PATH
QT_PLUGIN_PATH=/home/susan/Qt/5.7/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
QT_PLUGIN_PATH=/home/susan/Qt/5.12/gcc_64/plugins${QT_PLUGIN_PATH:+:$QT_PLUGIN_PATH}
export QT_PLUGIN_PATH
exec "$@"

0 comments on commit a034db9

Please sign in to comment.