Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 refactor #478

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reginald-mclean
Copy link
Collaborator

This PR re-organizes the Meta-World repository by:

  • removing the version 1 environments (we can keep the reward functions by adding a per environment flag about which reward function to use if desired, I think it might be a good idea)
  • moving environments from metaworld/envs/mujoco/sawyer_xyz/v2 to metaworld/envs
  • also move auxiliary files around that are imported/used by each environment

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, may only suggestion would be have a metaworld/envs/sawyer_xyz then all the current environments as at a future date, we could consider adding alternative environments and this will be obvious the different types

@pseudo-rnd-thoughts
Copy link
Member

I'm surprised that the test time hasn't reduced with this change. I would have thought removing half the environment would have reduced the time by 2.
I know you have answered this before @reginald-mclean but is it just a single test that takes most of the time?

@reginald-mclean
Copy link
Collaborator Author

@pseudo-rnd-thoughts I will run the tests locally to confirm, but the tests in tests/metaworld/envs/mujoco/sawyer_xyz/test_scripted_policies.py are most likely the lengthiest. They run the expert policy in each environment 50 times (one for each of those task objects created at initialization). The expert policy must achieve a success rate of 80% to pass the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants