Add params and rng argument to all FuncEnv member functions
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedTachyon
requested changes
Feb 25, 2024
| return state[1] > 0 | ||
|
|
||
|
|
||
| def test_api(): | ||
| env = BasicTestEnv() | ||
| state = env.initial(None) | ||
| obs = env.observation(state) | ||
| obs = env.observation(state, None) |
There was a problem hiding this comment.
Can we make the rng argument optional the same way as params?
There was a problem hiding this comment.
How should rng default be handled?
If an environment's needs transition member function requires rng, what should be done?
In the case of parameters, there is clearly a default
There was a problem hiding this comment.
|
@RedTachyon check the above comment Thanks |
Co-authored-by: Mark Towers <mark.m.towers@gmail.com> Co-authored-by: Pratik Ingle <prin@itu.dk> Co-authored-by: Jose Antonio Martin H <ja.martin.h@repsol.com> Co-authored-by: Oli <ollihaus@t-online.de> Co-authored-by: Jared Swift <j.w.swift@outlook.com> Co-authored-by: Tim Schneider <mail@tim-schneider.me> Co-authored-by: Tim Schneider <tim@robot-learning.de> Co-authored-by: Tim Schneider <tim.schneider94@t-online.de> Co-authored-by: Manuel Goulão <msilvagoulao@gmail.com> Co-authored-by: Michael Panchenko <35432522+MischaPanch@users.noreply.github.com> Co-authored-by: TobiasKallehauge <tkal@es.aau.dk> Co-authored-by: Ariel Kwiatkowski <ariel.j.kwiatkowski@gmail.com> Co-authored-by: James Mochizuki-Freeman <jameymmf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #851, #861
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)