Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean: Update glossiness API, to be able to have a default specular color if none provided #279

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

FarhadG
Copy link
Contributor

@FarhadG FarhadG commented Jun 12, 2015

A more intuitive glossiness API, along with a default specular color if none was provided (based off the light color).

@FarhadG
Copy link
Contributor Author

FarhadG commented Jun 12, 2015

Just FYI, this will break the old API, as the previous one required that you pass in a Color as the first argument (if not a material express) with a strength. Now, on the other hand, you pass in strength as the first argument and an optional Color for the second argument.

I will push up a demo for this, very soon.

@FarhadG
Copy link
Contributor Author

FarhadG commented Jun 15, 2015

All updates have been made and here's a DEMO showcasing the updates.

@michaelobriena

@michaelobriena
Copy link
Member

@FarhadG Can you update the commits so that the second commit is marked as a breaking change?

Thanks.

@FarhadG
Copy link
Contributor Author

FarhadG commented Jul 8, 2015

Updated to breaking commit.

@michaelobriena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants