Added requiredDestinationTypes on missionevents (solves #13941) #13948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds requiredDestinationTypes="outpost,city,research,military,mine" to all missionevents that give cargo/escort missions so they do not generate if there's no viable adjacent destination.
No more of this:
A side effect is that those missions will spawn less in practice as they will be picked at random by the eventset, but not trigger in the case of no adjacent outposts. If eventmanager generates its default 3 missionevents and 2 are cargo/escort, you will in practice only have 1 mission offered.
This is acceptable imo.
NOTE: STILL NEEDS ANYOUTPOST SUPPORT FOR MODS.
THESE SHOULD BE USING requiredDestinationTypes="AnyOutpost" WITH THE ABILITY TO DEFINE IF A LOCATIONTYPE CAN BE USED BY ANYOUTPOST
#13941