Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requiredDestinationTypes on missionevents (solves #13941) #13948

Conversation

ubertpendragon
Copy link

@ubertpendragon ubertpendragon commented May 10, 2024

Simply adds requiredDestinationTypes="outpost,city,research,military,mine" to all missionevents that give cargo/escort missions so they do not generate if there's no viable adjacent destination.

No more of this:
218220031-6ebe2701-3360-4565-b76e-107c0caac5bc

A side effect is that those missions will spawn less in practice as they will be picked at random by the eventset, but not trigger in the case of no adjacent outposts. If eventmanager generates its default 3 missionevents and 2 are cargo/escort, you will in practice only have 1 mission offered.

This is acceptable imo.

NOTE: STILL NEEDS ANYOUTPOST SUPPORT FOR MODS.
THESE SHOULD BE USING requiredDestinationTypes="AnyOutpost" WITH THE ABILITY TO DEFINE IF A LOCATIONTYPE CAN BE USED BY ANYOUTPOST

#13941

Added requiredDestinationTypes="outpost,city,research,military,mine" for all cargo/escort missions
Copy link
Collaborator

@Regalis11 Regalis11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be in a mergeable state yet, as you commented

NOTE: STILL NEEDS ANYOUTPOST SUPPORT FOR MODS.
THESE SHOULD BE USING requiredDestinationTypes="AnyOutpost" WITH THE ABILITY TO DEFINE IF A LOCATIONTYPE CAN BE USED BY ANYOUTPOST

@ubertpendragon
Copy link
Author

This does not seem to be in a mergeable state yet, as you commented

NOTE: STILL NEEDS ANYOUTPOST SUPPORT FOR MODS.
THESE SHOULD BE USING requiredDestinationTypes="AnyOutpost" WITH THE ABILITY TO DEFINE IF A LOCATIONTYPE CAN BE USED BY ANYOUTPOST

The PR itself does solve the issue for vanilla, but I'm not competent enough to make the necessary "AnyOutpost" changes that would ensure mod compatibility (for example, in DynamicEuropa, we add and override many location types, so we'd have to override the whole missionevents as well)

@Regalis11
Copy link
Collaborator

Regalis11 commented May 27, 2024

Implemented this with AnyOutpost support (which is imo a lot better than configuring the outpost types one by one like this) in our private repo https://github.com/FakeFishGames/Barotrauma-development/pull/5341

@Regalis11 Regalis11 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants