-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindings/rust: update bindgen version #4991
base: master
Are you sure you want to change the base?
Conversation
1fa1cb1
to
cb1e868
Compare
Thx, worked for me, I published the 0.11.1 packages. Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using. I created ElektraInitiative/opensesame#67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
With the new release everything is working now 👍 |
Is it expected that the macOS builds don't work or how can I fix them? Should we close this issue when ElektraInitiative/opensesame#67 is done? |
Only the Jenkins job is non-optional. The error there seems to be a spurious problem. It can be retriggered with commenting @atmaxinger will you review and merge? |
jenkins build libelektra please |
Update
bindgen
for rust bindings to 0.66.1 #4989.bindgen
changed some defaults regarding the equality ofusize
andsize_t
. They added the option.size_t_is_usize(true)
but made it defaulttrue
in a later version. When bumping thebindgen
versionthe error goes away. Read more about this in this issue and also here.
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels