Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/rust: update bindgen version #4991

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

horenso
Copy link

@horenso horenso commented Aug 20, 2023

Update bindgen for rust bindings to 0.66.1 #4989.

bindgen changed some defaults regarding the equality of usize and size_t. They added the option .size_t_is_usize(true) but made it default true in a later version. When bumping the bindgen version
the error goes away. Read more about this in this issue and also here.

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@coveralls
Copy link

coveralls commented Aug 20, 2023

Coverage Status

coverage: 99.913% (-0.001%) from 99.914% when pulling bde799d on fix-rust-binding into dbbe4ae on master.

@markus2330
Copy link
Contributor

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

I created ElektraInitiative/opensesame#67

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@fel115
Copy link

fel115 commented Aug 21, 2023

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

With the new release everything is working now 👍

@horenso
Copy link
Author

horenso commented Aug 21, 2023

Is it expected that the macOS builds don't work or how can I fix them? Should we close this issue when ElektraInitiative/opensesame#67 is done?

@markus2330
Copy link
Contributor

Only the Jenkins job is non-optional. The error there seems to be a spurious problem. It can be retriggered with commenting jenkins build libelektra please.

@atmaxinger will you review and merge?

@markus2330
Copy link
Contributor

jenkins build libelektra please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants