-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Mount tooling in C #4864
WIP: Mount tooling in C #4864
Conversation
and add command.h containing helpful macros and a struct def that is needed later
... to command.c for resolving bookmarks in keynames.
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
.. and remove cpp implementation
... and a GET_BASIC_OPTIONS macro for reading all basic basic options at the start of a command
... and (partial) fix ElektraInitiative#3742, fix ElektraInitiative#4028, fix ElektraInitiative#1164
... and (partial) fix ElektraInitiative#3742
.. and fix ElektraInitiative#3648
... and fix ElektraInitiative#3742
switch from the deprecated internal to external iteration
and check for failed kdbGet()
include header to some c-files for commands to fix linker errors
early stage, lots of open TODOs, work in progress
work in progress, not compiling
and some refactoring
4068491
to
57862d8
Compare
I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new PR with the remainder of this PR. |
I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new PR with the remainder of this PR. |
Basics
This PR has basically the same content as the PR #4851, but it should be merged into
kdb_cli_rewrite
instead ofmount_cli_integration
.I created a new branch based on the current version of the
kdb_cli_rewrite
branch.The upstream branch
mount_cli_integration
contains the commits ofkdb_cli_rewrite
and on top of that the commits for the mount-tooling, which are also included in this PR.The problem is, that the commits in
mount_cli_integration
that originally came fromkdb_cli_rewrite
have a different SHA1 than the commits inkdb_cli_rewrite
.This PR contains the original commits from
kdb_cli_rewrite
with the correct SHA1-hashes.tl;dr: The branch
mount_cli_integration
on upstream can be deleted.Then we have only
kdb_cli_rewrite
on upstream and my PRs are based on that branch and target it.(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels