Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI improvements #866

Merged
merged 6 commits into from
Nov 5, 2023
Merged

Web UI improvements #866

merged 6 commits into from
Nov 5, 2023

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Nov 5, 2023

  • fix Web UI: Warnings block execution #814
  • fix web UI warnings:
    • <div> in <p>
    • migrate from old Client Rendering API to new one
    • non-unique keys in error list component
  • add CPU Status indication
  • enable @smallg0at's code to conditionally disable the Load button

@codecov-commenter
Copy link

Codecov Report

Merging #866 (cff569b) into master (d60a050) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #866      +/-   ##
============================================
- Coverage     52.08%   52.02%   -0.06%     
  Complexity     1452     1452              
============================================
  Files           251      251              
  Lines         10226    10237      +11     
  Branches       1099     1101       +2     
============================================
  Hits           5326     5326              
- Misses         4579     4590      +11     
  Partials        321      321              
Files Coverage Δ
.../main/java/org/edumips64/client/ResultFactory.java 0.00% <0.00%> (ø)
src/main/java/org/edumips64/client/Worker.java 0.00% <0.00%> (ø)
src/main/java/org/edumips64/client/Simulator.java 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60a050...cff569b. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 866 November 5, 2023 17:19 Destroyed
@lupino3
Copy link
Member Author

lupino3 commented Nov 5, 2023

This is progress towards #852

@lupino3 lupino3 merged commit 3cf846e into master Nov 5, 2023
12 of 13 checks passed
@lupino3 lupino3 deleted the dev/lupino3/improve-gwt-simulator branch November 5, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI: Warnings block execution
2 participants