Skip to content

Commit

Permalink
fix: remove mention of changing static fields (#509)
Browse files Browse the repository at this point in the history
That's plain wrong.
  • Loading branch information
lupino3 committed Nov 8, 2020
1 parent 6c34be0 commit db3f918
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions docs/developer-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,4 @@ be automated, but before that is done those checks should be done manually.
- verify the JAR size (should be < 3 MB)
- open the English manual and check the version
- open the Italian manual and check the version
- check the 'edge' snap and promote it to stable if it works (https://snapcraft.io/edumips64/releases, needs login)

### Overriding instruction field values

Many instruction class contain static fields. This can be confusing and error-prone. If a concrete instruction
defines any fields that are defined in parent classes (such as, for example, `OPCODE_VALUE`), it is important that
the constructor also overrides the value of the same attribute for the superclass, or some methods will not work properly.

This is clearly too convoluted and should be redesigned in a way that makes it impossible to make mistakes.
- check the 'edge' snap and promote it to stable if it works (https://snapcraft.io/edumips64/releases, needs login)

0 comments on commit db3f918

Please sign in to comment.