Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: CLI Settings #2424

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat: CLI Settings #2424

wants to merge 4 commits into from

Conversation

DogeDark
Copy link
Member

Creates a setting system with 3 priorities:

  1. CLI Flags (e.g. --open or --hot-reload)
  2. Project-level config (e.g. Settings in Dioxus.toml)
  3. Global settings stored in local data.

Additions

  • dx config set_global command for always-hot-reload and always-open-browser
  • [cli_settings] key in Dioxus.toml with fields always_hot_reload and always_open_browser
  • Storage of global settings in a toml.

This PR is slightly breaking with changes to the CLI commands and the hot reload setting moved from [application] to [cli_settings].

@DogeDark DogeDark added enhancement New feature or request cli Related to the dioxus-cli program labels May 17, 2024
@DogeDark DogeDark added the breaking This is a breaking change label May 17, 2024
@DogeDark
Copy link
Member Author

Looks like the clippy issue is fixed in Autoformat rsx PR. This is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking This is a breaking change cli Related to the dioxus-cli program enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DogeDark @jkelleyrtp