Skip to content

Commit

Permalink
owned-by-oxford/Gemfile - explictly require rdf-rdfxml 3.2.1+
Browse files Browse the repository at this point in the history 
As linkeddata gem doesn't yet require this, we need to. This version
includes a fix for a bug which crashes the `seod generate` step
otherwise.

See ruby-rdf/rdf-rdfxml#40
  • Loading branch information
Nick Stokoe committed May 5, 2023
1 parent 5de4638 commit ab75546
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion owned-by-oxford/Gemfile
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
source "https://rubygems.org"
gem "se_open_data", :github => "SolidarityEconomyAssociation/se-open-data", :branch => "v2.1.9"
gem "airrecord"
gem "rdf-rdfxml", "~> 3.2.1"
gem "airrecord"

2 comments on commit ab75546

@abrisse
Copy link

@abrisse abrisse commented on ab75546 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wu-lee: You should not declare in your Gemfile ~> 3.2.1 which is too conservative, you should use ~> 3.2, >= 3.2.1 instead.

And you should commit the Gemfile.lock too when you update the Gemfile file otherwise it is desynchronized. Your Gemfile.lock still references rdf-rdfxml 3.2.0

@wu-lee
Copy link
Contributor

@wu-lee wu-lee commented on ab75546 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the unexpected comment! I'll take note.

Checking the semantics of ~>, you're right. Had assumed it always used the major version number as the upper bound.

You're right about the lock too, and I usually do commit it, in this case I may have not because this is still work in progress.

Please sign in to comment.