refactor: Split command/transcode.rs into discrete unit testable functions
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowed_transcode_formats with filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR follows on from #26
I'm new to rust and figured refactoring an existing project would be a useful exercise to learn the language - as such I'd recommend a thorough review as there may obvious things I've missed or am not aware of.
As it's a significant revision I'd recommend reviewing it commit-by-commit as each is a discrete refactoring
Notable changes
Mostly the changes are just extracting logic but these are worth noting in particular:
Previous behaviour skipped if there was no existing FLAC release, but this change ensure the specified torrent is FLAC which seemed more logical.
TranscodeCommandas immutable and passes it by referenceThis avoids partial moves without resorting to cloning and seems to be the more rust-like way of doing things
Testing
For the tests to work you will need to add some
.flacfiles tosamples/flacs/[TITLE]/[file_name].flacTo get tests running in CI some Open Source / Creative Commons could be downloaded and a mock api response created for them.