Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely handle misconfigured extensions #1161

Merged
merged 2 commits into from
May 26, 2024
Merged

Safely handle misconfigured extensions #1161

merged 2 commits into from
May 26, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented May 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1160

What is the new behavior?

We now safely handle extensions that aren't well configured, preventing a total crash of DevToys, logging failures, and when possible, displaying explicitly what's wrong.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux May 10, 2024 22:42
@veler veler merged commit 8d4ea06 into main May 26, 2024
5 of 6 checks passed
@veler veler deleted the fix1160 branch May 26, 2024 15:55
@btiteux btiteux linked an issue May 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App safe mode (DevToys Ver.2)
2 participants