Fix compile errors in the Verbs API #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we haven't tested the -DUSE_VERBS_API flag in a while, because there are a bunch of compile errors if you use it. Some are due to minor changes to Derecho's internals that were never propagated to verbs.hpp/cpp, like the ip_addr_t declaration moving inside the derecho namespace. The rest are due to the new OOB API only being implemented on LibFabrics. I added declarations for the OOB functions to the Verbs interface, with function bodies that simply throw exceptions, so that Derecho can at least compile with the Verbs interface (even if none of the OOB functions actually work).
While debugging the compile errors caused by enabling USE_VERBS_API, I noticed that connection_manager.hpp was improperly putting node_id_t into the global namespace even though we intended it to be scoped within derecho. This was inadvertently hiding a bunch of improper uses of node_id_t that should have been caught back when we first put node_id_t inside the derecho namespace.
My earlier commit that fixed USE_VERBS_API compile issues used the quotes style for including headers with full paths, but now we've changed to using the brackets style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we haven't used the Verbs version of SST and RDMC in a while, there were a bunch of compile errors if you actually used the -DUSE_VERBS_API flag. I fixed them so that Derecho can at least compile when you use this flag. This does not mean the Verbs API has been tested, though, and it definitely won't work with the new OOB memory buffer commands.