Renamed rpc_port to transfer_port globally #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's not likely that we will completely eliminate TCP sockets from ViewManager any time soon (see issues #118 and #157), we should at least make our usage of TCP less confusing. The port named "rpc_port" in all of our configuration files is actually not used for RPC operations at all, but for transferring Views and object state between nodes during a view change. Renaming this port will make it clear that there is no RPC activity going over TCP.
After some discussion we agreed that the longer name state_transfer_port was better, so I did another global rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's not likely that we will completely eliminate TCP sockets from ViewManager any time soon (see issues #118 and #157), we should at least make our usage of TCP less confusing. The port named "rpc_port" in all of our configuration files is actually not used for RPC operations at all, but for transferring Views and object state between nodes during a view change. Renaming this port will make it clear that there is no RPC activity going over TCP.
This change is simple and consists of only one commit, but I thought I would create a pull request before committing it to master because it will break everyone's existing config files once merged.