Fixed a missing dependency in CMakeLists for mproc_manager #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMakeLists declaration for mproc_manager did not declare its dependency on libwsong::ipc, so the build would fail with the error "wsong/ipc/ring_buffer.ipc could not be found" if libwsong is installed anywhere other than a default system directory like /usr/local/. Also fixed the install scripts that use mktemp to properly clean up after themselves and delete the temp directory after installing, like I did earlier in Derecho.
|
Thank you for identifying this! |
songweijia
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMakeLists declaration for mproc_manager did not declare its dependency on libwsong::ipc, so the build would fail with the error "wsong/ipc/ring_buffer.ipc could not be found" if libwsong is installed anywhere other than a default system directory like /usr/local/. Adding this declaration fixes it so the target's include path includes the installed location of libwsong when compiling.
Also fixed the install scripts that use mktemp to properly clean up after themselves and delete the temp directory after installing, like I did earlier in Derecho.