[WIP] Dataset bounding box example #360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
force-pushed
the
dataset_bounding_box
branch
3 times, most recently
from
fab570e
to
af7205a
Compare
Cadair
force-pushed
the
dataset_bounding_box
branch
from
af7205a
to
ba4afce
Compare
Cadair
force-pushed
the
dataset_bounding_box
branch
from
8ac600d
to
ece1830
Compare
Cadair
commented
Apr 3, 2024
Comment on lines
+74
to
+76
| corners = visp_spatial.wcs.array_index_to_world([0, visp_spatial.data.shape[0] - 0.5], | ||
| [0, visp_spatial.data.shape[1] - 0.5]) | ||
| corners |
There was a problem hiding this comment.
I think the fact that [-0.5, visp_spatial.data.shape[0] - 0.5] errors here (because of an out of bounds on the time lookup table) is indicative of a bug in the WCS in the ASDFs 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #349.