mydiracx extension extensions/src/mydiracx #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, we will keep this open, and start from this one after the workshop |
6 tasks
ruslan33
force-pushed
the
mydiracx-extension
branch
from
00aa3b6
to
3f800d2
Compare
ruslan33
force-pushed
the
mydiracx-extension
branch
from
c8c5dac
to
12b2d87
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ruslan33
force-pushed
the
mydiracx-extension
branch
from
7081d3a
to
12c6f02
Compare
ruslan33
force-pushed
the
mydiracx-extension
branch
from
e3ce12e
to
f5f4cf2
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
chaen
reviewed
Apr 9, 2024
| @@ -0,0 +1,5 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| __all__ = "DummyDB" | |||
| @@ -0,0 +1,56 @@ | |||
| from __future__ import annotations | |||
| @@ -0,0 +1,5 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| __all__ = "sql" | |||
| @@ -0,0 +1,294 @@ | |||
| from __future__ import annotations | |||
Comment on lines
5
to
17
| from typing import Annotated, TypeVar | ||
|
|
||
| from fastapi import Depends | ||
|
|
||
| from mydiracx.db.sql import DummyDB as _DummyDB | ||
|
|
||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def add_settings_annotation(cls: T) -> T: | ||
| """Add a `Depends` annotation to a class that has a `create` classmethod.""" | ||
| return Annotated[cls, Depends(cls.create)] # type: ignore | ||
|
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@ruslan33 as agreed I'll start from your PR and push it a bit further. Thanks a lot for it ! |
|
I'll close this one and continue your work in #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First prototype of diracx extension