-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Org common view #2406
Merged
Merged
Org common view #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
reviewed
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, a couple of things to improve (I can create a task for this, and you can address this later when we return to this project):
- Font-size of table headers should be 12px
- Use
pluralize
to format "project groups" copy. Result -> 1 project group, 2 project groups - When hovering the "x project groups" chips, we should see the name of the project groups. Check
getSegmentName
from 'segments.js' - When an organization doesn't have a logo, we display an icon as placeholder. That icon is not properly centered.
- At the bottom of the table, there are always 2 empty rows
- User should be able to sort the table by organization name (# of contacts and # of activities later)
- Organizations tab is missing the #organizations hash in the url. When I reload the page I'm redirected to the project groups tab.
- Organization and Actions column should be fixed -> When I scroll horizontally, the columns should be fixed and on top of all other columns
Once backend is ready:
- Add # of contacts and # of activities column
frontend/src/modules/organization/components/list/organization-common-list-table.vue
Show resolved
Hide resolved
joanagmaia
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature
,Improvement
, orBug
.