Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org common view #2406

Merged
merged 11 commits into from
May 21, 2024
Merged

Org common view #2406

merged 11 commits into from
May 21, 2024

Conversation

gaspergrom
Copy link
Contributor

Changes proposed ✍️

What

copilot:summary

copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom self-assigned this May 15, 2024
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, a couple of things to improve (I can create a task for this, and you can address this later when we return to this project):

  • Font-size of table headers should be 12px
  • Use pluralize to format "project groups" copy. Result -> 1 project group, 2 project groups
  • When hovering the "x project groups" chips, we should see the name of the project groups. Check getSegmentName from 'segments.js'
  • When an organization doesn't have a logo, we display an icon as placeholder. That icon is not properly centered.
  • At the bottom of the table, there are always 2 empty rows
  • User should be able to sort the table by organization name (# of contacts and # of activities later)
  • Organizations tab is missing the #organizations hash in the url. When I reload the page I'm redirected to the project groups tab.
  • Organization and Actions column should be fixed -> When I scroll horizontally, the columns should be fixed and on top of all other columns

Once backend is ready:

  • Add # of contacts and # of activities column

@gaspergrom gaspergrom merged commit 2651172 into crowd-linux May 21, 2024
5 checks passed
@gaspergrom gaspergrom deleted the feature/org-common-view branch May 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants