Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select AnalysisPaths options from the command line for analysis scripts #1221

Open
tahorst opened this issue Nov 8, 2021 · 1 comment
Open

Comments

@tahorst
Copy link
Member

tahorst commented Nov 8, 2021

Building off of an idea in #1220, it would be nice to be able to select AnaylsisPaths options like successful sims (new CLI option), seed range or generation ranges (can use existing --seed-range or --generation-range options but implement them for variant or cohort analysis) from the command line for the manual analysis scripts or even when building workflows. The AnalysisPaths object could be passed to each analysis script which could then select a further subset like some scripts already do.

The successful sims option should be expanded to allow the choice between only successful sims, sims with data (successful and failed during the generation) and all sim (successful, failed during, and never ran because a previous generation failed).

@tahorst
Copy link
Member Author

tahorst commented Jan 30, 2022

After #1250 there are still a few TODOs that could be addressed if desired.

  • update framework for comparison analysis type
  • add options to workflow creators (fw_queue or wcm)
  • add example script calls to docs to show the new options
  • The successful sims option should be expanded to allow the choice between only successful sims, sims with data (successful and failed during the generation) and all sim (successful, failed during, and never ran because a previous generation failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant