-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Simple table level sharding implementation #129
base: develop
Are you sure you want to change the base?
Conversation
auxten
commented
Dec 3, 2018
- Simple SELECT without GROUP, LIMIT offset, HAVING, DISTINCT
- Almost all kinds of INSERT without subqueries
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
===========================================
- Coverage 77.47% 76.51% -0.96%
===========================================
Files 142 149 +7
Lines 10251 11115 +864
===========================================
+ Hits 7942 8505 +563
- Misses 1684 1910 +226
- Partials 625 700 +75 |
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
==========================================
+ Coverage 76.74% 77% +0.26%
==========================================
Files 146 151 +5
Lines 10890 11313 +423
==========================================
+ Hits 8357 8712 +355
- Misses 1845 1898 +53
- Partials 688 703 +15 |
shard/engine_test.go
Outdated
So(err, ShouldNotBeNil) | ||
So(its, ShouldEqual, -1) | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is not formatted.
rowCh <-chan []interface{} | ||
) | ||
for i, ins := range instructions { | ||
colNames, _, rowCh, err = plan.selector(ctx, errCh, stopCh, ins, TempTableRowBufSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colNames
may not be the same schema as the original table.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. Please review @laodouya @auxten @xq262144 @leventeliu |