Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Stream over ReadOnlySequence<byte> #808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Stream over ReadOnlySequence<byte> #808

wants to merge 2 commits into from

Conversation

paulomorgado
Copy link

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

This PR adds a AsStream() extension method to ReadOnlySequence<byte> similarly to the same method for Memory<byte> and ReadOnlyMemory<byte>.

DaZombieKiller
DaZombieKiller reviewed Dec 7, 2023
View reviewed changes
src/CommunityToolkit.HighPerformance/Streams/ReadOnlySequenceStream.cs Outdated
public sealed override bool CanWrite
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
get => !this.disposed;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this always return false?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS!

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaZombieKiller DaZombieKiller DaZombieKiller left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulomorgado @DaZombieKiller