Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #451 - Add pragma restore directive for the CS0108 warning #773

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GabrieleMessina
Copy link
Contributor

@GabrieleMessina GabrieleMessina commented Oct 14, 2023

Closes #451

I've added a pragma restore directive for the CS0108 warning into the ObservableObject class source generator.

I haven't updated the tests to support the newly generated code yet. I want to be sure this can be a good solution before proceeding to that seeing that updating the test is a lot of work.
@Sergio0694 Can you confirm I can proceed?

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Code follows all style conventions

Other information

I've not found a way of testing the newly generated code on an actual class that inherits from ObservableObject.
When I try to add this kind of class nothing goes generated under the hood. There is a way of testing this like I'm working with the final nuget package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherited ViewModels can hide important warnings
1 participant