Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo clean-up for upcoming changes #4796

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Repo clean-up for upcoming changes #4796

wants to merge 10 commits into from

Commits on Oct 22, 2022

  1. Remove BOM from new files 

    Renormalize new lines and remove BOM from new files
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    4659c8c View commit details
    Browse the repository at this point in the history

  2. Remove redundant xml tags and attributes 

    - Remove `<?xml?>` file-type tag from all files.
- Remove `xmlns` and `ToolsVersion` attributes from project files.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    02224f0 View commit details
    Browse the repository at this point in the history

  3. Update Git ignore and attributes 

    - Add default Git attributes.
- Update Git ignores to latest.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    e489596 View commit details
    Browse the repository at this point in the history

  4. Ensure we preserve the encoding of UTF-16LE files 

    - Use `*.<encoding>.*` (like `*.UTF-16LE.*`) generalized naming scheme to mark differently encoded files.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3306af2 View commit details
    Browse the repository at this point in the history

  5. Update Icons and use Icon.png name instead 

    - Add `Icon.png` apart from `nuget.png`
  - This is used as a public reference point for NuGet icon URL. So, keep the original file.
  - If there's a need to update the icon, only update the new one `Icon.png` and keep the old one intact.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    8bcaab9 View commit details
    Browse the repository at this point in the history

  6. Rename solution, scripts and NuGet config files 

    - Rename solution file to `CommunityToolkit.Windows.sln`
  - The name starting with `Windows` doesn't stand-out in the file list because of the sort order of the `W` char.
  - Spaces are a main issue when doing automation (_like using `*.sln` in build scripts and in URLs it adds `%20`_).

- Fix casing for NuGet config files.

- Rename Smoke Tests PowerShell scripts.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ce7a511 View commit details
    Browse the repository at this point in the history

  7. Remove leftover files from previous refactors 

    - Remove empty leftover build files which are not being used anyway.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    8cd5355 View commit details
    Browse the repository at this point in the history

  8. Format Notifications package ReadMe 

    - Fix reported MarkdownLint warnings
- Format tables, use code blocks and adjust spacing.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    f5f2a9d View commit details
    Browse the repository at this point in the history

  9. Remove redundant code from project files 

    - Remove un-necessary attributes.
- Remove un-used `BinDir` item metadata.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    6b563f8 View commit details
    Browse the repository at this point in the history

  10. Update comments and fix mistakes 

    - Fix message text.
- Fix Include logic.
- Fix spelling mistakes.
- Fix leading whitespace.
- Fix casing in code and comments.
    @Nirmal4G
    Nirmal4G committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    fbb24ee View commit details
    Browse the repository at this point in the history