Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FlowDirection picker to SampleController #4516

Closed
wants to merge 1 commit into from

Conversation

Avid29
Copy link
Contributor

@Avid29 Avid29 commented Mar 21, 2022

Fixes #4515

Adds a flow direction option to the Sample Controller in the sample app

PR Type

Sample app changes

What is the current behavior?

None

What is the new behavior?

Flow Direction can be selected in the sample app

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
    (It does not appear I have permission to do this. I will need the branch created for me)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • Contains NO breaking changes

Other information

This feature has already helped me find a few bugs with the Carousel Control and Shadow Animations

@ghost
Copy link

ghost commented Mar 21, 2022

Thanks Avid29 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi March 21, 2022 22:37
@ghost ghost added the feature request 📬 A request for new changes to improve functionality label Mar 21, 2022
@Avid29 Avid29 deleted the branch CommunityToolkit:main March 23, 2022 12:36
@Avid29 Avid29 closed this Mar 23, 2022
@Avid29 Avid29 deleted the main branch March 23, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 📬 A request for new changes to improve functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Flow Direction demos for the sample app
1 participant