Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Flow Direction demos for the sample app #4515

Open
Avid29 opened this issue Mar 21, 2022 · 1 comment · May be fixed by #4521
Open

[Feature] Flow Direction demos for the sample app #4515

Avid29 opened this issue Mar 21, 2022 · 1 comment · May be fixed by #4521
Labels
feature request 📬 A request for new changes to improve functionality In-PR 🚀 labs 🧪 Marks an issue/PR involved with Toolkit Labs

Comments

@Avid29
Copy link
Contributor

Avid29 commented Mar 21, 2022 •
edited

Describe the problem

Proper right to left behavior isn't always clear. Toolkit maintainers likely don't test their controls in RTL flowing languages and developers writing with RTL flowing languages in mind don't always know the proper behavior.

Adding a Flow Direction option next to theme in the SampleController would at least allow Toolkit maintainers to easily test the behaviors of the controls more easily, and developers using the toolkit to more easily check the behavior of these controls in that context.

Describe the solution

I have added a Flow Direction ComboBox next to the theme ComboBox that changes the flow direction in the demo area.

image
image

Alternatives

Enter FlowDirection="RightToLeft" in the root element of the XAML page

Additional info

No response

Help us help you

No response
@Avid29 Avid29 added the feature request 📬 A request for new changes to improve functionality label Mar 21, 2022
@ghost
Copy link

ghost commented Mar 21, 2022

Hello, 'Avid29! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@Avid29 Avid29 mentioned this issue Mar 21, 2022
Closed
4 tasks
@ghost ghost added the In-PR 🚀 label Mar 21, 2022
@michael-hawker michael-hawker added the labs 🧪 Marks an issue/PR involved with Toolkit Labs label Mar 21, 2022
@ghost ghost removed the In-PR 🚀 label Mar 23, 2022
@Avid29 Avid29 linked a pull request Mar 23, 2022 that will close this issue
Open
4 tasks
@ghost ghost added the In-PR 🚀 label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 📬 A request for new changes to improve functionality In-PR 🚀 labs 🧪 Marks an issue/PR involved with Toolkit Labs
Projects
None yet
Milestone
No milestone
2 participants
@Avid29 @michael-hawker