Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Save symbol files (pdbs) to the pipeline artifacts #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JesseCol
Copy link

@JesseCol JesseCol commented May 20, 2021

Special thanks for @azchohfi who did most of the work here and helped me along!

What is the current behavior?

Before this change, the pipeline doesn't save out the PDB files.

What is the new behavior?

After this change, the pipeline will save Microsoft.Toolkit.Win32.UI.XamlHost_stripped.pdb to artifacts.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented May 20, 2021

Thanks JesseCol for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker May 20, 2021
@net-foundation-cla
Copy link

net-foundation-cla bot commented May 20, 2021

CLA assistant check
All CLA requirements met.

@JesseCol JesseCol changed the title Symbols in artifacts Save symbol files (pdbs) to the pipeline artifacts May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants