Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme token formatting #1718

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented May 14, 2024

Description

Formats tokens in themes to be bold or italic.

Related Issues

Checklist

  • Put UI in place to configure theme tokens to be bold and or or italic from within theme details in settings
  • Modify theme with these controls
  • Ensure that these new formatting properties work with the source editor to bold or italicize each token if configured to do so

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-05-14.at.5.28.13.PM.mp4

Before

Screen.Recording.2024-05-18.at.9.44.10.AM.mp4

After

Screen.Recording.2024-05-18.at.9.45.09.AM.mp4

@danielzsh
Copy link
Contributor

Will this do essentially what CodeEditApp/CodeEditSourceEditor#245 was trying to? If yes, I'll close my PR then 😅

@austincondiff
Copy link
Collaborator Author

@danielzsh Not really but we will probably need to adjust font weights in CESE in order for this to work, so we can address it all then. We really appreciate the effort, but go ahead and close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants