Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show information for non-text files in the status bar #1713

Merged
merged 22 commits into from
May 17, 2024
Merged

Show information for non-text files in the status bar #1713

merged 22 commits into from
May 17, 2024

Conversation

plbstl
Copy link
Contributor

@plbstl plbstl commented May 13, 2024

Description

This PR allows CodeEdit to show the file size of the currently opened file. And if the file is an image, CodeEdit also shows its dimensions.

I could not find a style for file information in the Figma concept.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

sample.pdf:

pdf

sample.heic:

sample-heic

sample.ods:

sample-ods

screenshot.png

screenshot-png

plbstl added 19 commits May 12, 2024 23:14
@plbstl
properly name utilityAreaViewModel across the project
48b0aea
@plbstl
add article docs for CodeEdit/UtilityAreaView
8c8aad3
@plbstl
update article docs for CodeEdit/StatusBarView
8f89c21
@plbstl
properly name items in CodeEdit/Features/UtilityArea/Toolbar
1a84281
@plbstl
remove UtilityAreaViewModel properties from status bar implementation
9000664
@plbstl
remove unused properties in UtilityAreaViewModel
fe5c5bb
@plbstl
delete CursorLocation model
cd8082e
@plbstl
rename StatusBarCursorLocationLabel to StatusBarCursorPositionLabel
6467f88
@plbstl
add StatusBarViewModel
71d30f7
@plbstl
show non-text file info in the status bar
60a2e65
@plbstl
fix unpredictable image dimensions in status bar
d83152a
@plbstl
add UpdateStatusBarInfo view modifier to clean up implementation
20837cb
@plbstl
move the NonTextFileView.onDisappear modifier to inside the view
c3f2138
@plbstl
change StatusBarViewModel.dimensions from tuple to struct
9b03181
@plbstl
refactor StatusBarFileInfoView
a5938ea
@plbstl
fix SwiftLint violation
c63d0ef
@plbstl
minor doc change in UpdateStatusBarInfo
cfd410c
@plbstl
remove unused editor variable in UpdateStatusBarInfo
773990c
@plbstl
refactor
a648652 
- stylistic changes
- docs change
- properly name `UtilityAreaSplitTerminalButton`
- remove unused `isBreakpointEnabled` in `StatusBarBreakpointButton`
@austincondiff austincondiff self-requested a review May 16, 2024 19:20
austincondiff
austincondiff previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CodeEdit/Features/StatusBar/Views/StatusBarItems/StatusBarFileInfoView.swift Outdated Show resolved Hide resolved
@austincondiff austincondiff self-requested a review May 16, 2024 19:22
austincondiff
austincondiff previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

Edit: just merge that conflict

@plbstl plbstl dismissed stale reviews from FastestMolasses and austincondiff via 817778f May 17, 2024 07:44
@plbstl
Copy link
Contributor Author

plbstl commented May 17, 2024

Thank you. I have resolved the conflict

@plbstl
properly resolve merge conflict
dcc3dba 
I used the GitHub UI, it didn't come out how I expected
@austincondiff austincondiff enabled auto-merge (squash) May 17, 2024 13:43
@austincondiff austincondiff merged commit 2f94292 into CodeEditApp:main May 17, 2024
2 checks passed
@austincondiff austincondiff mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@activcoding activcoding Awaiting requested review from activcoding

@austincondiff austincondiff Awaiting requested review from austincondiff

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plbstl @austincondiff @FastestMolasses